Make traits_in_crate and impls_in_crate proper queries.#129478
Make traits_in_crate and impls_in_crate proper queries.#129478xonx4l wants to merge 3 commits intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The title doesn't seem to reflect what is actually implemented in this PR: |
|
@compiler-errors I wrote that in reference to the issue and that's why I specified what implemented in pr note . |
|
Why not just change the title of the PR? Also, please run the formatter ( r? @cjgillot since you're mentoring this issue, though I'm happy to review it if you're busy. |
|
Preliminary questions:
|
|
Regarding sorting to preserve existing behavior I made an assumption about existing sorting behavior but after reviewing the code more carefully, I see that there isn't an existing sorting behavior for impls_in_crate that needs to be preserved. |
|
@xonx4l |
|
@xonx4l |
Issue -: #95092.
This PR introduces impls_in_crate as a query, maintaining current sorting behavior while setting the stage for future optimizations.
Benefits -:
Sorting is kept within the query for now to minimize changes. It Maintains existing behaviour while introducing the new query.